Correctly handle unification use site diagnostics in substituted named type symbols#53039
Merged
333fred merged 6 commits intodotnet:release/dev16.10from Apr 30, 2021
Merged
Correctly handle unification use site diagnostics in substituted named type symbols#53039333fred merged 6 commits intodotnet:release/dev16.10from
333fred merged 6 commits intodotnet:release/dev16.10from
Conversation
Member
Author
|
@dotnet/roslyn-compiler for a second review. |
AlekseyTs
reviewed
Apr 30, 2021
src/Compilers/CSharp/Portable/Symbols/SubstitutedNamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Apr 30, 2021
Added some new comments that require response
Member
Author
|
@AlekseyTs addressed your feedback. |
cston
reviewed
Apr 30, 2021
src/Compilers/CSharp/Test/Symbol/Symbols/GenericConstraintTests.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Apr 30, 2021
src/Compilers/CSharp/Portable/Symbols/SubstitutedNamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Apr 30, 2021
src/Compilers/CSharp/Portable/Symbols/SubstitutedNamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@cston addressed your comments. |
cston
approved these changes
Apr 30, 2021
jaredpar
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1279758/. @AlekseyTs @dotnet/roslyn-compiler for review.