Run LSP integration on rolling builds only until they're stable#53032
Merged
dibarbet merged 2 commits intodotnet:mainfrom Apr 30, 2021
Merged
Run LSP integration on rolling builds only until they're stable#53032dibarbet merged 2 commits intodotnet:mainfrom
dibarbet merged 2 commits intodotnet:mainfrom
Conversation
jaredpar
approved these changes
Apr 29, 2021
Member
|
I see an entry in the checks list for this PR for roslyn-integration-lsp-CI. Is that expected? |
Member
Author
|
@RikkiGibson good catch, I forgot that PR triggers are always on unless you explicitly turn them off |
RikkiGibson
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the LSP tests are optional and the github UI is deficient at differentiating optional tests from required, moving these tests to run on rolling builds only until we're ready to make these required.
These can be manually triggered by /azp to run on PRs if needed.
cc @sharwell