Add ServiceHub implementation of IDocumentTrackingService#52976
Merged
sharwell merged 3 commits intodotnet:mainfrom Apr 30, 2021
Merged
Add ServiceHub implementation of IDocumentTrackingService#52976sharwell merged 3 commits intodotnet:mainfrom
sharwell merged 3 commits intodotnet:mainfrom
Conversation
203d533 to
74e4dc9
Compare
src/Workspaces/Remote/ServiceHub/Services/ServiceHubDocumentTrackingService.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 28, 2021
Contributor
There was a problem hiding this comment.
so this is correct, but still problematic :-/ we do want a system whereby a user touches a document, and we update the 'designable' state for it in VS asap. Do we have any thoughts on how we might accomplish that moving forward?
Contributor
Author
There was a problem hiding this comment.
Diagnostic incremental analyzer handles this by running the solution crawler portion in devenv.exe and delegating the individual document/project analysis operations to OOP. For designer attribute discovery, we have a few options:
- Rely on Solution Crawler to minimize the number of document analysis operations that are requested following a document change. Analysis operations would directly prioritize open documents, but open documents would scan quickly following changes by nature of work being added to a short queue.
- Move designer attribute solution crawling to devenv.exe, and delegate to OOP similar to diagnostics.
- Leave this analyzer unchanged (essentially option 1), but add a parallel API that can perform targeted updates of a document following context switches (roughly a work-stealing approach).
This implementation helps identify problematic uses of transient state in remote invocations that are intended to be stateless.
…lable Incremental analyzers running in Solution Crawler out-of-process must not set 'HighPriorityForActiveFile'. Active file information is not available out-of-process, so these analyzers will never take the active files into account. Lower priority incremental analyzers do not explicitly request prioritized processing for active files, but the Solution Crawler still prioritized processing of these items when the information was available. This change automatically disables the prioritization feature for Solution Crawler running out-of-process.
74e4dc9 to
318b50b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation helps identify problematic uses of transient state in remote invocations that are intended to be stateless.