Skip to content

Do not show UI if no managed projects are loaded#52934

Merged
jmarolf merged 1 commit intodotnet:release/dev16.10from
jmarolf:bugfix/more-resilient-editor-factory-implementation
Apr 29, 2021
Merged

Do not show UI if no managed projects are loaded#52934
jmarolf merged 1 commit intodotnet:release/dev16.10from
jmarolf:bugfix/more-resilient-editor-factory-implementation

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Apr 26, 2021

Done at the request of the C++ team

@jmarolf jmarolf requested a review from a team as a code owner April 26, 2021 21:23
@ghost ghost added the Area-IDE label Apr 26, 2021
@jmarolf jmarolf force-pushed the bugfix/more-resilient-editor-factory-implementation branch from c70c924 to 2de59fd Compare April 26, 2021 21:42
Comment on lines 77 to 82
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this prevent the ability of just opening an .editorconfig loose? Or does that already not work for some other reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does that already not work for some other reason?

This will also prevent the "loose" problem where you are opening a editorconfig file and there are no projects at all, just files

Copy link
Member

@jasonmalinowski jasonmalinowski Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what if I want to open an .editorconfig loose and get the designer? Is that just not supported, even prior to this?

@jmarolf jmarolf changed the base branch from main to release/dev16.10 April 27, 2021 23:46
@jmarolf jmarolf requested a review from jasonmalinowski April 28, 2021 19:58
@jmarolf jmarolf enabled auto-merge April 29, 2021 17:16
@jmarolf jmarolf merged commit 92f460a into dotnet:release/dev16.10 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants