Fix syntactic range computation.#52672
Merged
CyrusNajmabadi merged 3 commits intodotnet:mainfrom Apr 16, 2021
Merged
Conversation
davidwengier
approved these changes
Apr 16, 2021
dibarbet
approved these changes
Apr 16, 2021
| // If the two nodes/tokens were the same just skip past them. They're part of the common right width. | ||
| if (currentOld.IsIncrementallyIdenticalTo(currentNew)) | ||
| // Critically though, we can only skip past if this wasn't already something we consumed when determining | ||
| // the common left width. If this was common the left side, we can't consider it common to the right, |
Member
There was a problem hiding this comment.
Suggested change
| // the common left width. If this was common the left side, we can't consider it common to the right, | |
| // the common left width. If this was common to the left side, we can't consider it common to the right, |
Member
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced with the recent cahnge to report a minimal text change to the editor for classification. In some cases, teh text change was too minimal, leading to us not classifying.