Remove use of Editor.INavigationBarItemService in LSP#52481
Merged
333fred merged 3 commits intodotnet:mainfrom Apr 10, 2021
Merged
Remove use of Editor.INavigationBarItemService in LSP#52481333fred merged 3 commits intodotnet:mainfrom
333fred merged 3 commits intodotnet:mainfrom
Conversation
Currently, the DocumentSymbolsHandler uses the editor version of INavigationBarItemService. Thanks to Cyrus's recent work around refactoring the nav bars for OOP, we now have a clean Features-layer API that we can seemlessly transition the handler to with minimal changes. I've done this, as well as a bit of general cleanup (enable nullable, fix a memory leak, a couple other things).
333fred
commented
Apr 8, 2021
src/Features/LanguageServer/Protocol/Handler/Symbols/DocumentSymbolsHandler.cs
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Symbols/DocumentSymbolsHandler.cs
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Symbols/DocumentSymbolsHandler.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 8, 2021
dibarbet
approved these changes
Apr 9, 2021
src/Features/LanguageServer/Protocol/Handler/Symbols/DocumentSymbolsHandler.cs
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Symbols/DocumentSymbolsHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Symbols/DocumentSymbolsHandler.cs
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Apr 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the DocumentSymbolsHandler uses the editor version of INavigationBarItemService. Thanks to Cyrus's recent work around refactoring the nav bars for OOP, we now have a clean Features-layer API that we can seemlessly transition the handler to with minimal changes. I've done this, as well as a bit of general cleanup (enable nullable, fix a memory leak, a couple other things).