Do not fire TagsChanged for the copy/paste classifier.#52417
Merged
CyrusNajmabadi merged 4 commits intodotnet:mainfrom Apr 6, 2021
Merged
Do not fire TagsChanged for the copy/paste classifier.#52417CyrusNajmabadi merged 4 commits intodotnet:mainfrom
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
Conversation
sharwell
approved these changes
Apr 5, 2021
Contributor
Author
|
Disabling auto-merge. This PR is insufficient. We still need to address https://github.com/dotnet/roslyn/blob/main/src/EditorFeatures/Core/Implementation/Classification/SyntacticClassificationTaggerProvider.TagComputer.cs#L224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by an internal discussion where an editor investigation found a high amount of work caused by these notifications we issue.