Skip to content

Delete duplicate test#52393

Merged
davidwengier merged 1 commit intodotnet:mainfrom
Youssef1313:patch-8
Apr 5, 2021
Merged

Delete duplicate test#52393
davidwengier merged 1 commit intodotnet:mainfrom
Youssef1313:patch-8

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 3, 2021

No description provided.

@Youssef1313 Youssef1313 requested a review from a team as a code owner April 3, 2021 09:46
@ghost ghost added the Area-IDE label Apr 3, 2021
Youssef1313
Youssef1313 commented Apr 3, 2021
View reviewed changes
src/EditorFeatures/CSharpTest/InitializeParameter/AddParameterCheckTests.cs
Comment on lines -407 to -419
[Fact, Trait(Traits.Feature, Traits.Features.CodeActionsInitializeParameter)]
public async Task TestNotOnExternMethod()
{
var code = @"
using System;

class C
{
extern void M([||]string s);
}";
await VerifyCS.VerifyRefactoringAsync(code, code);
}

Copy link
Member Author

@Youssef1313 Youssef1313 Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact duplicate of:

roslyn/src/EditorFeatures/CSharpTest/InitializeParameter/AddParameterCheckTests.cs

Lines 182 to 193 in ee340b0

[Fact, Trait(Traits.Feature, Traits.Features.CodeActionsInitializeParameter)]
public async Task TestNotOnExternParameter()
{
var code = @"
using System;
class C
{
extern void M([||]string s);
}";
await VerifyCS.VerifyRefactoringAsync(code, code);
}

@Youssef1313
Copy link
Member Author

Youssef1313 commented Apr 3, 2021 

Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpInteractive.BclMathCall
System.Exception : Unable to find expected content in REPL within 60000 milliseconds and no exceptions were thrown.
Expected:
[[> ]]Actual:
[[Microsoft (R) Visual C# Interactive Compiler version 3.10.0-ci ()
Loading context from 'CSharpInteractive.rsp'.
Type "#help" for more information.
> #reset 64
Resetting execution engine.
]]

😕

@Youssef1313 Youssef1313 closed this Apr 3, 2021
@Youssef1313 Youssef1313 reopened this Apr 3, 2021
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 5, 2021
@davidwengier davidwengier merged commit e62a01a into dotnet:main Apr 5, 2021
@ghost ghost added this to the Next milestone Apr 5, 2021
@davidwengier
Copy link
Member

davidwengier commented Apr 5, 2021

Thanks!

@Youssef1313 Youssef1313 deleted the patch-8 branch April 6, 2021 02:33
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees

@davidwengier davidwengier

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

16.10.P3

Development

Successfully merging this pull request may close these issues.

4 participants

@Youssef1313 @davidwengier @dibarbet @jinujoseph