Skip to content

Some clean up in anyc completion #52381

Merged
genlu merged 2 commits intodotnet:mainfrom
genlu:CleanUp
Apr 6, 2021
Merged

Some clean up in anyc completion #52381
genlu merged 2 commits intodotnet:mainfrom
genlu:CleanUp

Conversation

@genlu
Copy link
Copy Markdown
Member

@genlu genlu commented Apr 2, 2021

  • Enabled nullable ref
  • Removed unused code

FYI @davidwengier I checked on //index, but you might want do make sure removed code isn't used by VS4Mac

@genlu genlu requested a review from a team as a code owner April 2, 2021 22:43
@ghost ghost added the Area-IDE label Apr 2, 2021
Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on the VS Mac side of things by the look of it. They have their own copy of PrioritizedTaskScheduler, so don't use ours.

@genlu genlu merged commit 2d9cbc2 into dotnet:main Apr 6, 2021
@ghost ghost added this to the Next milestone Apr 6, 2021
@genlu genlu deleted the CleanUp branch April 6, 2021 18:20
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants