Skip to content

Task 1285177: [LSP] Support Pull Diagnostics correctly for local client#52369

Merged
mgoertz-msft merged 2 commits intodotnet:mainfrom
LinglingTong:dev/ltong/task1285177
Apr 6, 2021
Merged

Task 1285177: [LSP] Support Pull Diagnostics correctly for local client#52369
mgoertz-msft merged 2 commits intodotnet:mainfrom
LinglingTong:dev/ltong/task1285177

Conversation

@LinglingTong
Copy link
Copy Markdown
Contributor

@LinglingTong LinglingTong commented Apr 2, 2021

Changes in this PR:

  1. Add HintedSuggestion to XamlDiagnosticSeverity and handle this new severity in AbstractPullDiagnosticHandler.

What is HintedSuggestion?
HintedSuggestion is a new error Severity XAML added lately to support errors that show the "..." marker in editor but don't show up in the error list.

  1. Switch to listening to Workspace.DocumentClosed event instead of RDT OnBeforeLastDocumentUnlock in XamlProjectService. RunningDocumentTableEventTracker is also listening to OnBeforeLastDocumentUnlock and will fire a DocumentClosed event for it. This OnBeforeLastDocumentUnlock inside RunningDocumentTableEventTracker is doing the same check as we have in XamlProjectService. There is no need for us to do duplicate work and meanwhile as we remove the XAML file when the file gets closed this will ensure the file only gets removed after the DocumentClosed event gets fired.

@LinglingTong LinglingTong requested a review from a team as a code owner April 2, 2021 17:53
@ghost ghost added the Area-IDE label Apr 2, 2021
@LinglingTong
Copy link
Copy Markdown
Contributor Author

Comment thread src/VisualStudio/Xaml/Impl/Implementation/XamlProjectService.cs Outdated
Copy link
Copy Markdown
Contributor

@mgoertz-msft mgoertz-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mgoertz-msft mgoertz-msft merged commit 5fb4608 into dotnet:main Apr 6, 2021
@ghost ghost added this to the Next milestone Apr 6, 2021
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants