Conversation
91114ea to
a0d33dc
Compare
| # CA1012: Abstract types should not have constructors | ||
| dotnet_diagnostic.CA1012.severity = warning |
There was a problem hiding this comment.
❔ Can we move this to one of the .globalconfig files? The parsing performance of those files is better than .editorconfig, and they are more consistently applied to the code base.
There was a problem hiding this comment.
If we feel parsing performance is an issue, can we file a compiler bug for it to improve editorconfig performance? Also we should consider moving everything over from editorconfig to globalconfig instead of just one off changes.
There was a problem hiding this comment.
If we feel parsing performance is an issue, can we file a compiler bug for it to improve editorconfig performance?
The .editorconfig parsing performance is very good, but by definition has to be applied per-file. .globalconfig doesn't need to consider paths. The latter is also preferable because duplication definitions trigger a warning rather than silently ignoring one of them.
Co-authored-by: Manish Vasani <mavasani@microsoft.com>
Related to #52359