Fix Quick Info integration tests#52354
Conversation
| protected void WaitForQuickInfo() | ||
| { | ||
| VisualStudioInstance.Workspace.WaitForAsyncOperations(Helper.HangMitigatingTimeout, FeatureAttribute.DiagnosticService); | ||
| VisualStudioInstance.Workspace.WaitForAsyncOperations(Helper.HangMitigatingTimeout, FeatureAttribute.ErrorSquiggles); |
There was a problem hiding this comment.
don't we still need to wait on some of these? otherwise quick info may come up before squiggles have, and then it won't show the diag data in it? or is that not a problem for some other reason?
There was a problem hiding this comment.
All calls to GetQuickInfo are preceded by calls to InvokeQuickInfo. The latter covers the cases.
| { | ||
| ThreadHelper.JoinableTaskFactory.Run(async () => | ||
| { | ||
| await ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync(); |
There was a problem hiding this comment.
@sharwell Why the SwitchToMainThreadAsync here if the GetQuickInfo doesn't have that?
There was a problem hiding this comment.
For the call to GetActiveTextView()
There was a problem hiding this comment.
GetQuickInfo also has it, but it's implicit in the ExecuteOnActiveView call.
|
What library is JoinableTaskFactory included with? I'm unable to build any of the Extensibility projects using the community preview edition.
|
|
@scott-weeden That looks like a question for microsoft/VSExtensibility. |
No description provided.