Offer href as completion attribute for <see/> doc comments#52342
Merged
sharwell merged 3 commits intodotnet:mainfrom Apr 2, 2021
Merged
Offer href as completion attribute for <see/> doc comments#52342sharwell merged 3 commits intodotnet:mainfrom
sharwell merged 3 commits intodotnet:mainfrom
Conversation
sharwell
approved these changes
Apr 1, 2021
sharwell
suggested changes
Apr 1, 2021
Contributor
sharwell
left a comment
There was a problem hiding this comment.
Needs to be added for <seealso>
Youssef1313
commented
Apr 1, 2021
Comment on lines
53
to
+57
| new[] { SeeElementName, CrefAttributeName, $"{CrefAttributeName}=\"", "\"" }, | ||
| new[] { SeeElementName, LangwordAttributeName, $"{LangwordAttributeName}=\"", "\"" }, | ||
| new[] { SeeElementName, HrefAttributeName, $"{HrefAttributeName}=\"", "\"" }, | ||
| new[] { SeeAlsoElementName, CrefAttributeName, $"{CrefAttributeName}=\"", "\"" }, | ||
| new[] { SeeAlsoElementName, HrefAttributeName, $"{HrefAttributeName}=\"", "\"" }, |
Member
Author
There was a problem hiding this comment.
Unrelated: Should langword be offered in <seealso/>?
Contributor
There was a problem hiding this comment.
no, langword is just for see
sharwell
approved these changes
Apr 1, 2021
This was referenced Apr 1, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37504