Add PathUtilities.CombinePaths with same semantics as Path.Combine#52322
Merged
tmat merged 5 commits intodotnet:mainfrom Apr 5, 2021
Merged
Add PathUtilities.CombinePaths with same semantics as Path.Combine#52322tmat merged 5 commits intodotnet:mainfrom
tmat merged 5 commits intodotnet:mainfrom
Conversation
Member
Author
|
@dotnet/roslyn-compiler PTAL |
jaredpar
approved these changes
Apr 4, 2021
Co-authored-by: Jared Parsons <jaredpparsons@gmail.com>
chsienki
reviewed
Apr 5, 2021
| /// <param name="root">First path: absolute, relative, or null.</param> | ||
| /// <param name="path">Second path: absolute, relative, or null.</param> | ||
| /// <returns> | ||
| /// The combined paths. If <paramref name="path"/> contains an absolute path, returns <paramref name="root"/>. |
Member
There was a problem hiding this comment.
Doesn't it return path when it's an absolute path?
chsienki
approved these changes
Apr 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds tests.