Pass CancellationToken in compilers layer#52281
Merged
jmarolf merged 1 commit intodotnet:mainfrom Mar 31, 2021
Merged
Conversation
7 tasks
333fred
approved these changes
Mar 31, 2021
Member
|
I was caught off guard by the merge with only one approval. It looks like this other approval is for the same set of changes as this PR: #52247 (review). So I suppose it is alright. |
Member
|
@jmarolf please remember that compiler PRs require 2 sign offs, not just one. @dotnet/roslyn-compiler, please take a second, retroactive review. I don't believe that this will need to have any changes, but it does need a second review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #52247
This cleans up passing cancellation tokens in the compiler layer