Move to Arcade 6 by JoeRobich · Pull Request #52255 · dotnet/roslyn

JoeRobich · 2021-03-30T17:02:18Z

builds off the work in #51647

Signed build (MS only): https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4606420&view=results

jmarolf · 2021-03-31T11:02:21Z

We are now getting the error that I saw in my original PR:

Compilation error(s) occurred:  Cannot use file stream for [D:\workspace_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.CSharp.CommandLine.UnitTests\Debug\net5.0\testhost.deps.json]: No such file or directory
A fatal error was encountered. The library 'hostpolicy.dll' required to execute the application was not found in 'D:\workspace_work\1\s.dotnet'.
Failed to run as a self-contained app.

    The application was run as a self-contained app because 'D:\workspace_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.CSharp.CommandLine.UnitTests\Debug\net5.0\testhost.runtimeconfig.json' was not found.
    If this should be a framework-dependent app, add the 'D:\workspace_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.CSharp.CommandLine.UnitTests\Debug\net5.0\testhost.runtimeconfig.json' file and specify the appropriate framework.

For some reason several runtime files are not being deployed and/or the .NET 6 SDK now has more stringent logic about what files need to be there.

JoeRobich · 2021-03-31T15:59:08Z

@jmarolf What do you make of this issue dotnet/arcade#6371 (comment)? Does it seem like the problem we are running into?

global.json

src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs

jmarolf · 2021-03-31T16:04:24Z

@jmarolf What do you make of this issue dotnet/arcade#6371 (comment)? Does it seem like the problem we are running into?

oof, that looks like it. I guess we will need to either re-write our tests or fix arcade

JoeRobich · 2021-03-31T16:05:49Z

oof, that looks like it. I guess we will need to either re-write our tests or fix arcade

The macos and Linux tests pass because i assume the runner is executed by the dotnet cli. I guess perhaps they include a shim for the windows platform and it is the shim that is invoked instead of the dotnet cli.

JoeRobich · 2021-03-31T16:44:57Z

oof, that looks like it.

Good news is that is not it =)

jmarolf · 2021-03-31T17:24:41Z

Good news is that is not it =)

Cool beans. I guess this is an SDK team question then if we believe its not arcade.

JoeRobich · 2021-03-31T18:38:19Z

@jmarolf Pretty sure I got it this time.

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>

JoeRobich · 2021-03-31T21:09:59Z

Seeing this error with the InteractiveHost.UnitTests when run on Windows_CoreClr. cc: @tmat, @sharwell for ideas on what to do next

tmat · 2021-03-31T21:18:01Z

@JoeRobich InteractiveHost targets: <TargetFrameworks>net472;net5.0-windows7.0</TargetFrameworks>
So my guess is that we need have that installed on the test machine, or roll-forward.

JoeRobich · 2021-03-31T21:21:24Z

So my guess is that we need have that installed on the test machine, or roll-forward.

That makes sense since the tests no longer run on the same machine that performs the build.

jmarolf · 2021-03-31T21:22:27Z

paging @RikkiGibson how do we check what is installed on the helix machines?

eng/pipelines/test-windows-job.yml

tmat · 2021-04-01T18:54:54Z

src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs

+  <PropertyGroup>
+    <!-- Disable automatic global .editorconfig generation by the SDK --> 
+    <GenerateMSBuildEditorConfigFile>false</GenerateMSBuildEditorConfigFile>
+  </PropertyGroup>


Couldn't we include this in VerifyValues helper for all tests?

I feel like being explicit here isn't a bad thing. Certainly, if it became a problem to keep up with, we can extract it in the future.

tmat · 2021-04-01T18:56:17Z

eng/Tools.props

+    <!-- SourceLink -->
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="$(MicrosoftSourceLinkVersion)" PrivateAssets="all" IsImplicitlyDefined="true" />
+    <PackageReference Include="Microsoft.SourceLink.AzureRepos.Git" Version="$(MicrosoftSourceLinkVersion)" PrivateAssets="all" IsImplicitlyDefined="true" />
+  </ItemGroup>


Any idea why do we need this? Seems like something that should be handled by Arcade.

@jmarolf I stole this from your PR. Is it necessary?

hmm based on my run without the Tools.props (rolsyn CI). I see Jon opened this issue dotnet/arcade#7054. Which seems like the failure is on this line https://github.com/dotnet/arcade/blob/0b4d6253f298a5f9d6e2c4bd20e1de33a6763061/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L50

I wonder if having this conditionally included is somehow the source of the issue https://github.com/dotnet/arcade/blob/0b4d6253f298a5f9d6e2c4bd20e1de33a6763061/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj#L32

I am confused by this line https://github.com/dotnet/arcade/blob/0b4d6253f298a5f9d6e2c4bd20e1de33a6763061/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj#L115. Is it removing the Publish property before the Tools.proj is restored?

I am confused by this line

I believe this is to override the default .NET SDK behaviors here and provide our own

So boils down to Roslyn CI runs -restore separate from -publish. The Tools.proj is only Restored during a restore, but the "Microsoft.DotNet.Build.Tasks.Feed" package is conditioned on publish.

jmarolf · 2021-04-01T18:58:29Z

@JoeRobich be sure to send a mail notifying everyone that they need to update to .NET 6 Preview 1 (and we also need to update the contributor docs for this)

Move to Arcade 6

bc7724e

ghost added the Area-Infrastructure label Mar 30, 2021

jmarolf mentioned this pull request Mar 30, 2021

upgrade to version 6 of the Arcade sdk #51647

Closed

JoeRobich force-pushed the arcade6 branch 2 times, most recently from dd05957 to 9f55b02 Compare March 30, 2021 20:12

Disable MSBuild global .editorconfig generation in tests

e594724

JoeRobich force-pushed the arcade6 branch from 9f55b02 to e594724 Compare March 30, 2021 20:27

JoeRobich marked this pull request as ready for review March 30, 2021 21:24

JoeRobich requested review from a team as code owners March 30, 2021 21:24

runfoapp bot mentioned this pull request Mar 30, 2021

Roslyn failing to clean up listeners #48816

Closed

JoeRobich requested a review from a team as a code owner March 30, 2021 23:29

copy run settings to output directory

b328cc7

JoeRobich force-pushed the arcade6 branch from a89a67c to b328cc7 Compare March 31, 2021 00:17

sharwell reviewed Mar 31, 2021

View reviewed changes

global.json Outdated Show resolved Hide resolved

sharwell reviewed Mar 31, 2021

View reviewed changes

src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs Outdated Show resolved Hide resolved

sharwell reviewed Mar 31, 2021

View reviewed changes

src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs Outdated Show resolved Hide resolved

JoeRobich added 3 commits March 31, 2021 09:16

Fix indentation and add comments in DotNetSdkTests

f0ba0e8

Fix type in global.json

6b4af2a

Downgrade to NET 6 Preview 1

0f7fe00

sharwell approved these changes Mar 31, 2021

View reviewed changes

JoeRobich added 2 commits March 31, 2021 11:28

Fix CommandLineTests for .NET Core

cca1285

Move DotNetCoreSdk to shared test utilities

563bd03

Fix indentation in DotNetSdkTests

21c4317

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>

JoeRobich force-pushed the arcade6 branch from a7fe6e1 to 21c4317 Compare March 31, 2021 18:49

jmarolf reviewed Mar 31, 2021

View reviewed changes

eng/pipelines/test-windows-job.yml Outdated Show resolved Hide resolved

JoeRobich force-pushed the arcade6 branch from 582af3c to 00bd85c Compare March 31, 2021 23:22

Set prerelease rollforward when running tests

c675245

JoeRobich force-pushed the arcade6 branch from 00bd85c to c675245 Compare April 1, 2021 00:46

JoeRobich added 2 commits April 1, 2021 09:24

Set DOTNET_ROLL_FORWARD in Helix

f8d42ee

Set DOTNET_ROLL_FORWARD on single machien jobs

f99b204

jmarolf approved these changes Apr 1, 2021

View reviewed changes

tmat reviewed Apr 1, 2021

View reviewed changes

Update contributing doc

c7bc7e4

runfoapp bot mentioned this pull request Apr 1, 2021

Agents canceling during dotnet builds jaredpar/runfo#47

Closed

JoeRobich added 4 commits April 3, 2021 10:34

Remove sourcelink section from tools.props

27efe55

Merge branch 'arcade6-4' into arcade6

e8b4d7b

Update Windows build instructions to reference VS 16.9

9769613

Update comment in Tools.props

28fbc2d

JoeRobich mentioned this pull request Apr 8, 2021

Should Microsoft.DotNet.Build.Tasks.Feed be conditionally referenced dotnet/arcade#7205

Closed

2 tasks

RikkiGibson self-assigned this Apr 8, 2021

JoeRobich merged commit c0e6f58 into dotnet:main Apr 12, 2021

ghost added this to the Next milestone Apr 12, 2021

dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021

jmarolf mentioned this pull request Feb 7, 2022

Add repo files to Roslyn.sln and Compilers.sln as solution items #59328

Closed

JoeRobich deleted the arcade6 branch March 14, 2025 23:42

Conversation

JoeRobich commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmarolf commented Mar 31, 2021

Uh oh!

JoeRobich commented Mar 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmarolf commented Mar 31, 2021

Uh oh!

JoeRobich commented Mar 31, 2021

Uh oh!

JoeRobich commented Mar 31, 2021

Uh oh!

jmarolf commented Mar 31, 2021

Uh oh!

JoeRobich commented Mar 31, 2021

Uh oh!

JoeRobich commented Mar 31, 2021

Uh oh!

tmat commented Mar 31, 2021

Uh oh!

JoeRobich commented Mar 31, 2021

Uh oh!

jmarolf commented Mar 31, 2021

Uh oh!

Uh oh!

tmat Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

JoeRobich Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

tmat Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

JoeRobich Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

JoeRobich Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoeRobich Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoeRobich Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

jmarolf Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

JoeRobich Apr 2, 2021

Choose a reason for hiding this comment

Uh oh!

jmarolf commented Apr 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JoeRobich commented Mar 30, 2021 •

edited

Loading

JoeRobich Apr 1, 2021 •

edited

Loading

JoeRobich Apr 1, 2021 •

edited

Loading