Skip to content

Fix doc comment#52173

Merged
1 commit merged intodotnet:mainfrom
CyrusNajmabadi:fixDocs
Mar 26, 2021
Merged

Fix doc comment#52173
1 commit merged intodotnet:mainfrom
CyrusNajmabadi:fixDocs

Conversation

@CyrusNajmabadi
Copy link
Contributor

The doc comment for PatternMatcher is incorrect. it states it is threadsafe when it is not. SPecifically, internally for each 'chunk' of the pattern it breaks out, it keeps a 'similarity cache' of hte last thing it was matched against. this is so that checking it repeatedly against the same name (common with things like overloads, or candidate strings with similar portions) can jsut return the previously computed result. this cache is mutable and is not safe for concurrent mutation.

I have audited all users and have seen that no one does actually use this across threads. However, the docs shouldn't convey the wrong info here.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 26, 2021 19:26
@ghost ghost added the Area-IDE label Mar 26, 2021
@ghost ghost merged commit 7ff7779 into dotnet:main Mar 26, 2021
@ghost ghost added this to the Next milestone Mar 26, 2021
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the fixDocs branch April 11, 2021 18:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants