Merged
Conversation
sharwell
approved these changes
Mar 26, 2021
Cosifne
approved these changes
Mar 26, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc comment for PatternMatcher is incorrect. it states it is threadsafe when it is not. SPecifically, internally for each 'chunk' of the pattern it breaks out, it keeps a 'similarity cache' of hte last thing it was matched against. this is so that checking it repeatedly against the same name (common with things like overloads, or candidate strings with similar portions) can jsut return the previously computed result. this cache is mutable and is not safe for concurrent mutation.
I have audited all users and have seen that no one does actually use this across threads. However, the docs shouldn't convey the wrong info here.