Update IDEDiagnosticIDConfigurationTests to be exclusive rather than inclusive#52078
Merged
genlu merged 2 commits intodotnet:mainfrom Mar 25, 2021
Merged
Update IDEDiagnosticIDConfigurationTests to be exclusive rather than inclusive#52078genlu merged 2 commits intodotnet:mainfrom
genlu merged 2 commits intodotnet:mainfrom
Conversation
Member
Author
|
The test fails for RE0001 as expected. But the expected entry is: Is that correct given that the analyzer passes some option: |
Contributor
|
This looks to be expected @Youssef1313 there is no editorconfig storage location specified in this option: So it cannot be persisted to editorconfig files. |
jmarolf
approved these changes
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was skipping "RE0001" analyzer (probably unintentionally?)
Let's see what analyzers will fail the test now.