Skip to content

Remove usages of ConfigureAwait in tests#52070

Merged
333fred merged 2 commits intodotnet:mainfrom
Youssef1313:configawait
Apr 6, 2021
Merged

Remove usages of ConfigureAwait in tests#52070
333fred merged 2 commits intodotnet:mainfrom
Youssef1313:configawait

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

Fixes #6980

(Afraid if any of them is needed?)

@Youssef1313 Youssef1313 requested a review from a team as a code owner March 23, 2021 07:56
@ghost ghost added the Area-Compilers label Mar 23, 2021
@333fred
Copy link
Copy Markdown
Member

333fred commented Apr 6, 2021

@jaredpar can you look at this, particularly the compiler server tests?

@jaredpar
Copy link
Copy Markdown
Member

jaredpar commented Apr 6, 2021

What's the motivation for the change here? True we don't require code to be explicit about ConfigureAwait in the tests but it's not wrong either.

@Youssef1313
Copy link
Copy Markdown
Member Author

What's the motivation for the change here? True we don't require code to be explicit about ConfigureAwait in the tests but it's not wrong either.

#6975 (comment) (Not sure if this still holds?)

@333fred 333fred merged commit e5e5f94 into dotnet:main Apr 6, 2021
@ghost ghost added this to the Next milestone Apr 6, 2021
@333fred
Copy link
Copy Markdown
Member

333fred commented Apr 6, 2021

Thanks @Youssef1313!

@Youssef1313 Youssef1313 deleted the configawait branch April 6, 2021 19:08
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all usages of ConfigureAwait in tests

4 participants