Skip to content

Consistent ContainsSyntaxTree behavior between VB and C##52050

Merged
AlekseyTs merged 2 commits intodotnet:mainfrom
Youssef1313:patch-53
Mar 24, 2021
Merged

Consistent ContainsSyntaxTree behavior between VB and C##52050
AlekseyTs merged 2 commits intodotnet:mainfrom
Youssef1313:patch-53

Conversation

@Youssef1313
Copy link
Member

Fixes #27095

@Youssef1313 Youssef1313 requested a review from a team as a code owner March 22, 2021 15:00
@ghost ghost added the Area-Compilers label Mar 22, 2021
@jcouv jcouv added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 22, 2021
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@AlekseyTs
Copy link
Contributor

@dotnet/roslyn-compiler Please review. Need a second sign-off for a small community PR.

@AlekseyTs AlekseyTs merged commit 7859e2d into dotnet:main Mar 24, 2021
@ghost ghost added this to the Next milestone Mar 24, 2021
@AlekseyTs
Copy link
Contributor

@Youssef1313 Thanks for the contribution.

@Youssef1313 Youssef1313 deleted the patch-53 branch March 24, 2021 07:47
@333fred 333fred mentioned this pull request Mar 25, 2021
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VB and C# compiler APIs disagree on behavior of *Compilation.ContainsSyntaxTree

5 participants