Fix null annotation of SyntaxFactory.UsingStatement#51984
Merged
jcouv merged 3 commits intodotnet:mainfrom Mar 23, 2021
Merged
Conversation
cston
approved these changes
Mar 19, 2021
RikkiGibson
reviewed
Mar 19, 2021
| public partial class SyntaxFactory | ||
| { | ||
| public static UsingStatementSyntax UsingStatement(SyntaxToken usingKeyword, SyntaxToken openParenToken, VariableDeclarationSyntax declaration, ExpressionSyntax expression, SyntaxToken closeParenToken, StatementSyntax statement) | ||
| public static UsingStatementSyntax UsingStatement(SyntaxToken usingKeyword, SyntaxToken openParenToken, VariableDeclarationSyntax? declaration, ExpressionSyntax? expression, SyntaxToken closeParenToken, StatementSyntax statement) |
Member
There was a problem hiding this comment.
Should similar annotations be added to UsingStatementSyntax.Update methods above? #Resolved
cston
approved these changes
Mar 19, 2021
RikkiGibson
approved these changes
Mar 19, 2021
Member
|
@Youssef1313 looks like there's a conflict here. |
Member
|
Can be merged/squashed once CI is green. I just restarted some integration legs. |
Member
|
Merged/squashed. Thanks @Youssef1313 ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51924