Don't report rude edits for using declaration changes#51977
Don't report rude edits for using declaration changes#51977davidwengier merged 9 commits intodotnet:mainfrom
Conversation
|
@tmat in case you hadn't seen this |
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks good modulo the ifdef in the test.
Let's also make the same change for VB - can be a separate PR.
Let's file an issue to follow up on in future (if necessary) to detect semantic changes caused by changed using directives and report warnings on them.
| roslynTrigger = new CompletionTrigger(CompletionTriggerKind.Snippets); | ||
| } | ||
|
|
||
| var disallowAddingImports = _isDebuggerTextView || |
There was a problem hiding this comment.
@genlu for completion changes.
This doesn't actually fix the issue, but at least the items show up in completion. Somehow the session properties still have DisallowAddingImports set to true, but I haven't been able to work out where that comes from yet. I set breakpoints everywhere that its set to true, and they don't get hit ¯_(ツ)_/¯
Not going to block this PR on that though.
There was a problem hiding this comment.
Nevermind, cleaned out my hive and this does fix it. Caches be caching I guess? ¯\_(ツ)_/¯
|
Proof! (before I fixed completion)
|
|
|
Gonna merge this because it's Friday for me, and we can sneak it into P2. Gen I'll follow up with any completion changes you want. |
Fixes #10043
This turned out really straight forward. Let me know there are more tests to cover.