Rename record equality parameters to 'left' and 'right'#51973
Merged
RikkiGibson merged 3 commits intodotnet:mainfrom Mar 20, 2021
Merged
Rename record equality parameters to 'left' and 'right'#51973RikkiGibson merged 3 commits intodotnet:mainfrom
RikkiGibson merged 3 commits intodotnet:mainfrom
Conversation
|
|
Member
|
In general, changing parameter names would be a breaking change since callers may use explicit argument names. But I think we're okay because those are operators. We'd need a corresponding update to the spec: |
Contributor
Author
|
I have created a pull request for the required spec changes here dotnet/csharplang#4555 |
cston
reviewed
Mar 18, 2021
...mpilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityOperatorBase.cs
Show resolved
Hide resolved
To reflect changes to record equality operators
cston
approved these changes
Mar 19, 2021
Member
|
Planning to merge this afternoon, once we're sure that there's no objection from the language design team. |
Member
|
Thanks for your contribution @C-xC-c! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49300