Move code back from quick info to SymbolDisplay.#51961
Move code back from quick info to SymbolDisplay.#51961CyrusNajmabadi merged 9 commits intodotnet:mainfrom
Conversation
| AddDocumentationContent(firstSymbol); | ||
| } | ||
|
|
||
| private void AddDocumentationContent(ISymbol symbol) |
There was a problem hiding this comment.
moving back from qi to symbol-display.
| var sections = ImmutableArray.CreateBuilder<QuickInfoSection>(initialCapacity: groups.Count); | ||
|
|
||
| void AddSection(string kind, ImmutableArray<TaggedText> taggedParts) | ||
| => sections.Add(QuickInfoSection.Create(kind, taggedParts)); |
There was a problem hiding this comment.
helper local functions moved to bottom.
...rvices/SymbolDisplayService/AbstractSymbolDisplayService.AbstractSymbolDescriptionBuilder.cs
Show resolved
Hide resolved
| { | ||
| var result = new Dictionary<SymbolDescriptionGroups, ImmutableArray<TaggedText>>(_documentationMap); | ||
| foreach (var (group, parts) in _groupMap) | ||
| result[group] = parts.ToTaggedText(); |
There was a problem hiding this comment.
I don't understand this. Why are we replacing documentation text with symbol text?
There was a problem hiding this comment.
there are two maps. one that goes from group->symboparts, and one that goes from group->taggedtext. the maps cover different groups. So this just produces a final merged dictionary that is entirely from group->taggedtext.
|
|
||
| var remarksDocumentationContent = GetRemarksDocumentationContent(workspace, symbol, groups, semanticModel, token, formatter, cancellationToken); | ||
| if (!remarksDocumentationContent.IsDefaultOrEmpty) | ||
| var remarksDocumentation = GetRemarksDocumentationContent(workspace, groups, semanticModel); |
There was a problem hiding this comment.
nit: might as well just inline this since it's a very simple method and to be consistent with code below.
genlu
left a comment
There was a problem hiding this comment.
LGTM, except the one question I have
This will help with #51846, removing unnecessary copying between xaml and Roslyn's QI providers.