Merged
Conversation
Youssef1313
commented
Mar 17, 2021
| debugPlusMode As Boolean, | ||
| xmlReferenceResolver As XmlReferenceResolver, | ||
| sourceReferenceResolver As SourceReferenceResolver, | ||
| SyntaxTreeOptionsProvider As SyntaxTreeOptionsProvider, |
Member
Author
There was a problem hiding this comment.
Parameter usages are already in lowercase. But the IDE was automatically turning them PascalCased on save because of the actual parameter name here.
Member
|
It looks like this might be a source breaking change for C# callers of this method when argument labels are used. Are we alright with that? |
Member
Author
|
@RikkiGibson It's a private constructor. |
RikkiGibson
approved these changes
Mar 17, 2021
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
Oops, I didn't look high enough above the fold 😄. LGTM.
Member
|
@dotnet/roslyn-compiler for review |
cston
approved these changes
Mar 17, 2021
Member
|
This is running into flaky VS integration tests. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.