EnC - Support for records#51926
Merged
davidwengier merged 61 commits intodotnet:mainfrom Apr 14, 2021
Merged
Conversation
…when fields or properties change.
…e other rude edits
Member
Author
|
Updated and fixed most of the comments, still need to add more tests/expand tests for the EnC log, but that will have to wait for next week. |
tmat
reviewed
Apr 8, 2021
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 8, 2021
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 8, 2021
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 8, 2021
src/Features/CSharp/Portable/EditAndContinue/CSharpEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 8, 2021
src/Features/CSharp/Portable/EditAndContinue/CSharpEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 8, 2021
src/Features/CSharp/Portable/EditAndContinue/CSharpEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 8, 2021
src/Features/CSharp/Portable/EditAndContinue/CSharpEditAndContinueAnalyzer.cs
Show resolved
Hide resolved
This reverts commit e7e57af.
tmat
reviewed
Apr 12, 2021
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Apr 13, 2021
Member
333fred
left a comment
There was a problem hiding this comment.
Compiler changes LGTM (commit 60). @dotnet/roslyn-compiler for a second review.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44877
This covers the cases I can think of, though its possible I've been thinking about it too long and can't see the forest for the trees :)