Support directly assigning nameof to var#51885
Closed
Rekkonnect wants to merge 1 commit intodotnet:mainfrom
Closed
Support directly assigning nameof to var#51885Rekkonnect wants to merge 1 commit intodotnet:mainfrom
Rekkonnect wants to merge 1 commit intodotnet:mainfrom
Conversation
Breaks a test case for currently unknown reasons
Member
|
@alfasgd, while I appreciate the enthusiasm, this issue was specifically rejected by LDM, and thus not open for implementation. For reference, only things in the Any Time milestone are open for community contributions: https://github.com/dotnet/csharplang/milestone/14. Because this was rejected, I'm going to close this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP prototype for #4384
Notes:
nameofand return astring, since it uses a hack that adjusts the resulting expression type tostring, as it's not possible to bypass the recursive calculation of the resultant typenameofbecomes a non-contextual keywordAs a result of the last note, this PR may be closed and discarded completely until that chagne occurs.
CC @333fred