Ignore static Main methods in NamingStyle analyzer#51831
Merged
jmarolf merged 4 commits intodotnet:mainfrom Apr 15, 2021
Merged
Ignore static Main methods in NamingStyle analyzer#51831jmarolf merged 4 commits intodotnet:mainfrom
jmarolf merged 4 commits intodotnet:mainfrom
Conversation
Youssef1313
commented
Mar 12, 2021
Youssef1313
commented
Mar 12, 2021
Youssef1313
commented
Mar 12, 2021
Member
Author
|
@CyrusNajmabadi Can you review please? Thanks. |
| if (string.IsNullOrEmpty(symbol.Name)) | ||
| if (string.IsNullOrEmpty(symbol.Name) || | ||
| // Heuristic for recognizing entry points. | ||
| symbol.IsStatic && symbol.Name == WellKnownMemberNames.EntryPointMethodName) |
Contributor
There was a problem hiding this comment.
we have an existing helper for this: IsEntryPoint
can you extrac tthis out (an extension on IMethodSymbol would be fine) and use the same for both?
Contributor
There was a problem hiding this comment.
yeah, this method should be extracted out to a general helper and used here.
Contributor
|
thanks @Youssef1313 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49648
Fixes #50734