Merged
Conversation
CyrusNajmabadi
commented
Mar 11, 2021
|
|
||
| // should not crash | ||
| await VerifyItemExistsAsync(markup, "ToString"); | ||
| await VerifyNoItemsExistAsync(markup); |
Contributor
Author
There was a problem hiding this comment.
this test was bogus. we shoudl not have offered completion here. teh cleanup simplified code and ended up fixing this.
genlu
reviewed
Mar 11, 2021
| filterOutOfScopeLocals = false; | ||
| } | ||
| } | ||
| filterOutOfScopeLocals = !_context.LeftToken.GetRequiredParent().IsFoundUnder<LocalDeclarationStatementSyntax>(d => d.Declaration.Type); |
Member
There was a problem hiding this comment.
The original code is easier to understand for me. Can we just merge the if statements instead?
genlu
reviewed
Mar 11, 2021
| if (symbol.Kind is SymbolKind.NamedType or SymbolKind.Namespace) | ||
| { | ||
| return ImmutableArray<ISymbol>.Empty; | ||
| // For named typed and namespaces, we flip things around. We only want statics and not instance members. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on this as part of "intellisense for operators/conversions". These methods often confuse the heck out of me. So i'm just working on making the data flow and checks clearer and simpler.