Add SolutionFilter support to MSBuildWorkspace#51782
Merged
JoeRobich merged 3 commits intodotnet:mainfrom Mar 19, 2021
Merged
Conversation
jmarolf
approved these changes
Mar 11, 2021
Therzok
reviewed
Mar 13, 2021
| { | ||
| public static bool IsSolutionFilterFilename(string filename) | ||
| { | ||
| return Path.GetExtension(filename) == ".slnf"; |
Contributor
There was a problem hiding this comment.
Shouldn't this be case insensitive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if MSBuild provided us a way to get the filtered list of projects from the loaded SolutionFile, Filter support would then be tied to having a sufficiently recent MSBuild. Reading the filter file separately allows these changes to work even with versions of MSBuild that did not contain support.
Based on the changes in dotnet/msbuild#4899