[LSP] Disable text sync for C# in 16.9#51708
Merged
dibarbet merged 3 commits intodotnet:release/dev16.9-vs-depsfrom Mar 10, 2021
Merged
[LSP] Disable text sync for C# in 16.9#51708dibarbet merged 3 commits intodotnet:release/dev16.9-vs-depsfrom
dibarbet merged 3 commits intodotnet:release/dev16.9-vs-depsfrom
Conversation
davidwengier
approved these changes
Mar 6, 2021
23ad525 to
91ce75d
Compare
CyrusNajmabadi
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables text sync for C# in 16.9 due to https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1287570
The current known issues are on the LSP client but the fixes are in their refactoring.
We disable text sync for C# for the following reasons
We leave it enabled for razor for a couple reasons.
f846b17 should be reverted in 16.10 as we've somewhat mitigated the restarting issue and there are additional LSP client logs to help diagnose issues. Will followup with PR as soon as this merges to main.
6bc956f adds extra logging for text sync to 16.9 so for scenarios where it is enabled (razor) we have logs to show the issue.
FYI @jinujoseph