Skip to content

Update MicrosoftNetFrameworkReferenceAssembliesVersion#51596

Closed
RikkiGibson wants to merge 1 commit intomainfrom
dev/rigibson/update-framework-ref-assemblies
Closed

Update MicrosoftNetFrameworkReferenceAssembliesVersion#51596
RikkiGibson wants to merge 1 commit intomainfrom
dev/rigibson/update-framework-ref-assemblies

Conversation

@RikkiGibson
Copy link
Member

It feels like this version should match the MicrosoftNETFrameworkReferenceAssembliesnet461Version, etc.

@RikkiGibson RikkiGibson requested a review from a team as a code owner March 2, 2021 21:28
@ghost ghost added the Area-Infrastructure label Mar 2, 2021
@RikkiGibson
Copy link
Member Author

CI failures look like:

src/Compilers/Test/Utilities/VisualBasic/CompilationTestUtils.vb(1217,22): error BC30455: Argument not specified for parameter 'Number' of 'Public Function Str(Number As Object) As String'.

this makes it seem like the preview contains certain VB core methods that the stable does not, which is odd.

@jaredpar
Copy link
Member

jaredpar commented Mar 2, 2021

this makes it seem like the preview contains certain VB core methods that the stable does not, which is odd.

Actually it makes sense. I remember us having to make changes here because we found the assembly was wrong at some point.

@RikkiGibson
Copy link
Member Author

@jaredpar does this mean that the assemblies in the "stable" version of these reference assemblies are wrong, and the ones in the earlier "preview" version are right?

@jaredpar
Copy link
Member

jaredpar commented Mar 3, 2021

@RikkiGibson

does this mean that the assemblies in the "stable" version of these reference assemblies are wrong, and the ones in the earlier "preview" version are right?

That matches my memories of this. I tracked down the point where we moved to this package and it's PR #29827.

@tmat may remember why we needed the non-RTM packages here. My vague memory is that this is still the time when we were dealing with the issues around MS.VB.dll being incomplete. It took a while to find all the places where the incomplete version was being published and fix it to have the complete one. This is likely another one of those cases

Base automatically changed from master to main March 3, 2021 23:53
@RikkiGibson
Copy link
Member Author

I'm dropping this work for now, assuming that the necessary workarounds are being pursued in #51647

@RikkiGibson RikkiGibson closed this Mar 9, 2021
@RikkiGibson RikkiGibson deleted the dev/rigibson/update-framework-ref-assemblies branch March 9, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants