Change queue time metrics to bucket by 10ms up to 1000ms. 50ms was n…#51575
Merged
dibarbet merged 1 commit intodotnet:mainfrom Mar 17, 2021
Merged
Change queue time metrics to bucket by 10ms up to 1000ms. 50ms was n…#51575dibarbet merged 1 commit intodotnet:mainfrom
dibarbet merged 1 commit intodotnet:mainfrom
Conversation
…t granular enough to spot differences and the number of requests beyond 1000ms was insignificant.
src/Features/LanguageServer/Protocol/Handler/RequestExecutionQueue.RequestTelemetryLogger.cs
Show resolved
Hide resolved
davidwengier
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ot granular enough to spot differences and the number of requests beyond 1000ms was insignificant.
The number of requests above 1000ms is basically insignificant (0.0046%) and the bucket size 50ms is not enough to differentiate requests as 97.48% fell into that bucket. So changing this to be more granular.