Skip to content

Fix official build pipeline in dnceng#51496

Merged
1 commit merged intodotnet:release/dev16.9from
genlu:FixAzdoPublish
Feb 26, 2021
Merged

Fix official build pipeline in dnceng#51496
1 commit merged intodotnet:release/dev16.9from
genlu:FixAzdoPublish

Conversation

@genlu
Copy link
Member

@genlu genlu commented Feb 25, 2021

@genlu genlu requested a review from a team as a code owner February 25, 2021 22:09
@ghost ghost added the Area-Infrastructure label Feb 25, 2021
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genlu
Copy link
Member Author

genlu commented Feb 26, 2021

@JoeRobich FYI I have made more changes after you signed off

@genlu genlu changed the title Fix nuget publish in dnceng Fix official build pipeline in dnceng Feb 26, 2021
@JoeRobich
Copy link
Member

@genlu my only thought is that we may want to rebase these changes and target release/dev16.9 since it will be a LTS release.

@genlu
Copy link
Member Author

genlu commented Feb 26, 2021

@JoeRobich Makes sense. Will do. Who's approval is required?

@genlu genlu changed the base branch from master to release/dev16.9 February 26, 2021 18:04
@genlu genlu requested review from a team as code owners February 26, 2021 18:04
@genlu genlu requested a review from a team February 26, 2021 18:04
@genlu genlu changed the base branch from release/dev16.9 to master February 26, 2021 18:04
@JoeRobich
Copy link
Member

Who's approval is required?

No special approvals needed for infrastructure changes.

Use access token to do master validation
@genlu genlu changed the base branch from master to release/dev16.9 February 26, 2021 19:02
@genlu
Copy link
Member Author

genlu commented Feb 26, 2021

@JoeRobich Done

@RikkiGibson
Copy link
Member

I'd be interested in reviewing once an official build run of this pipeline is available from dnceng as well as from devdiv.

@genlu
Copy link
Member Author

genlu commented Feb 26, 2021

@RikkiGibson I have tested insertion validation change in dnceng, for example:
https://dev.azure.com/dnceng/internal/_build/results?buildId=1012902&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=20fcf628-b65c-5865-625a-1cef81cda63b

Testing asset publication change would require changes to publishdata, so I will just let the real run test it.

Those fixes should have no impact on devdiv pipeline

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 55649ea into dotnet:release/dev16.9 Feb 26, 2021
@genlu genlu deleted the FixAzdoPublish branch February 26, 2021 20:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants