Don't try converting a metadata reference to a self project reference#51453
Merged
jasonmalinowski merged 2 commits intodotnet:masterfrom Feb 25, 2021
Merged
Conversation
We already had a message that included places to fill in the project names; so let's just use that. Also have a different message if you're adding a self-reference since that's really not good.
If a user messes up their project files in a way that results in a metadata reference to the output of itself, we shouldn't throw exceptions.
CyrusNajmabadi
approved these changes
Feb 24, 2021
ryzngard
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the exception in AB#1279845; the root cause was a misconfigured user project which I've helped them with directly.
While I'm here I'm also going to improve the exceptions thrown so this is more diagnosable in the future.