Handle multi-targeted projects in UnusedReferencesRemover#51347
Merged
JoeRobich merged 2 commits intodotnet:release/dev16.10from Feb 21, 2021
Merged
Handle multi-targeted projects in UnusedReferencesRemover#51347JoeRobich merged 2 commits intodotnet:release/dev16.10from
JoeRobich merged 2 commits intodotnet:release/dev16.10from
Conversation
ryzngard
approved these changes
Feb 20, 2021
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
Minor feedback. Overall looks good
| var projects = solution.Projects | ||
| .Where(project => projectFilePath.Equals(project.FilePath, System.StringComparison.OrdinalIgnoreCase)); | ||
|
|
||
| HashSet<string> usedAssemblyFilePaths = new(); |
Contributor
There was a problem hiding this comment.
nit: have we decided we're using this instead of var usedAssemblyFilePaths = new HashSet<string>()?
src/VisualStudio/Core/Def/Implementation/UnusedReferences/ProjectAssets/ProjectAssetsReader.cs
Outdated
Show resolved
Hide resolved
...isualStudio/Core/Def/Implementation/UnusedReferences/RemoveUnusedReferencesCommandHandler.cs
Outdated
Show resolved
Hide resolved
b5300c7 to
9d83e12
Compare
9d83e12 to
8f9c650
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building our list of references, we add the compilation assemblies from each used target. When building our list of used compilation assemblies, we add the used assemblies from all projects with the same path (each target gets their own project instance). When determine if a reference is used, we consider it used if even one targets compilation assembly is used.
implements part of #50054