Skip to content

Recommend struct and class keywords after record#51304

Merged
CyrusNajmabadi merged 2 commits intodotnet:features/record-structsfrom
Youssef1313:struct-recommender-for-record
Mar 8, 2021
Merged

Recommend struct and class keywords after record#51304
CyrusNajmabadi merged 2 commits intodotnet:features/record-structsfrom
Youssef1313:struct-recommender-for-record

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 18, 2021

(Not sure if it's that simple)

@jcouv Feel free to close if this doesn't match with the plans.

Test plan: #51199

@Youssef1313 Youssef1313 requested a review from a team as a code owner February 18, 2021 10:14
@ghost ghost added the Area-IDE label Feb 18, 2021
@CyrusNajmabadi
Copy link
Contributor

Don't we need the same for the class keyword?

@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Feb 18, 2021
@jcouv jcouv added the Feature - Records Records label Feb 18, 2021
@jcouv
Copy link
Member

jcouv commented Feb 18, 2021

@Youssef1313 Thanks :-)
class should also be offered as Cyrus pointed out.

@Youssef1313
Copy link
Member Author

Thanks @CyrusNajmabadi and @jcouv. Added the same check for classes as well

@Youssef1313 Youssef1313 changed the title Recommend struct keyword after record Recommend struct and class keywords after record Feb 18, 2021
@CyrusNajmabadi
Copy link
Contributor

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit e51131c into dotnet:features/record-structs Mar 8, 2021
@Youssef1313 Youssef1313 deleted the struct-recommender-for-record branch March 8, 2021 18:22
@jcouv jcouv mentioned this pull request Mar 30, 2021
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - Records Records

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants