Ensure we compute LSP server capabilities on UI thread before load#51295
Merged
jasonmalinowski merged 1 commit intodotnet:release/dev16.9-vs-depsfrom Feb 24, 2021
Conversation
dibarbet
approved these changes
Feb 18, 2021
src/VisualStudio/Core/Def/Implementation/LanguageClient/AbstractInProcLanguageClient.cs
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
should we potentially switch back off the UI thread here, so that the creation of the connection, instantiating the LSP server can happen off of the uI thread?
Member
Author
There was a problem hiding this comment.
So it looks like this API was already being called on the UI thread; I agree conceptually that it's the right thing to do, but worried about added risk. Thoughts?
Member
There was a problem hiding this comment.
Ah, if it's already on it then I'm OK with this - switching off would then be a new path (and potential for bugs).
17ee348 to
807b944
Compare
CyrusNajmabadi
approved these changes
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Fixes" https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1261421 in the sense it's a complete and total tactical fix. For 16.9 I think this is the lowest-risk thing we can do to address it, and we'll do the better fixes in 16.10.
This is directly targeting releases/dev16.9-vs-deps because targeting releases/dev16.9 runs into a bunch of merge conflicts; once we ship 16.9 we'll merge this back into releases/dev16.9 and then the fix will be in master where we can do the further cleanups.