Skip to content

Merge master to master-vs-deps#51240

Merged
26 commits merged intomaster-vs-depsfrom
merges/master-to-master-vs-deps
Feb 16, 2021
Merged

Merge master to master-vs-deps#51240
26 commits merged intomaster-vs-depsfrom
merges/master-to-master-vs-deps

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is an automatically generated pull request from master into master-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/master-to-master-vs-deps
git reset --hard upstream/master-vs-deps
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-master-vs-deps --force

Youssef1313 and others added 26 commits January 15, 2021 15:09
Only compute the unrooted symbol set for FinalState.
IDE0004 Redundant cast: False positive for IntPtr -> nint -> int
* Remove CSharpInteractiveEvaluator

* Move SendToInteractiveSubmissionProvider to EditorFeatures

* Remove IScriptEnvironmentService.

Fixes #45490

* Make props private

* Fix CanExecuteCode

* InteractiveSession

* Remove IW dependencies

* Move InteractiveWorkspace to EditorFeatures

* Cleanup completion #r, #load providers

* Move completion providers to C# EditorFeatures

* Delete Microsoft.CodeAnalysis.CSharp.EditorFeatures.Wpf

* Move directive completion providers to Features

* Add back command completion

* Fix path completion provider

* Initialize InteractiveWorkspace with solution analyzer references

* Rename InteractiveEvaluator

* Better error reporting in interactive integration tests.

* SolutionAnalyzerSetter
…213.12 (#51231)

[master] Update dependencies from dotnet/roslyn
IDE0004 Redundant cast: False positive for IntPtr -> nint -> int
Support records in CSharpGenerateDefaultConstructorsService
@dotnet-bot dotnet-bot requested review from a team as code owners February 16, 2021 03:02
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 07b9d1d into master-vs-deps Feb 16, 2021
@ghost ghost added this to the Next milestone Feb 16, 2021
@ghost ghost deleted the merges/master-to-master-vs-deps branch February 16, 2021 04:12
@dotnet-bot dotnet-bot restored the merges/master-to-master-vs-deps branch February 16, 2021 06:03
@RikkiGibson RikkiGibson modified the milestones: Next, 16.10.P1 Feb 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants