Add UI for editorconfig files by jmarolf · Pull Request #51069 · dotnet/roslyn

jmarolf · 2021-02-08T16:44:53Z

This is the new UI that will appear when a developer opens an editorconfig file (note a user can still get to the old file view via "Open With..")

Feature walkthrough:

Searching

Filtering

Sorting

Saving

Formatting Tab

Code Style Tab

Analyzers Tab

TODO:

Finish adding tests for editorconfig saving helpers
Update Tools -> Options window to use new services
Unify editorconfig saving types
Remove/fix all //TODO(jmarolf) comments

Youssef1313

nit: typo

src/EditorFeatures/Core/SettingsData/Analyzers/AnalyzerSettingInfo.cs

mavasani · 2021-02-08T17:20:25Z

@jmarolf Do you have UI screenshots?

src/EditorFeatures/Core/SettingsData/Analyzers/AnalyzerSettingsUpdaterService.cs

src/EditorFeatures/Core/SettingsData/CodeStyle/CodeStyleSetting.cs

src/EditorFeatures/Core/SettingsData/Whitespace/WhitespaceSetting.cs

src/VisualStudio/Core/Def/SettingsEditor/Analyzers/ColumnDefinitions/EnabledColumnDefinition.cs

.../Def/SettingsEditor/Analyzers/ViewModel/AnalyzerSettingsViewModel.SettingsEntriesSnapshot.cs

.../Def/SettingsEditor/Analyzers/ViewModel/AnalyzerSettingsViewModel.SettingsSnapshotFactory.cs

src/VisualStudio/Core/Def/SettingsEditor/Analyzers/ViewModel/AnalyzerSettingsViewModel.cs

src/VisualStudio/Core/Def/SettingsEditor/CodeStyle/CodeStyleSettingsViewModel.cs

src/VisualStudio/Core/Def/SettingsEditor/Helpers/TableKeyNames.cs

CyrusNajmabadi · 2021-02-08T18:06:41Z

Pictures plz @jmarolf .

CyrusNajmabadi · 2021-02-12T23:32:03Z

Pictures plz @jmarolf .

jmarolf · 2021-02-18T01:23:23Z

@CyrusNajmabadi I pictured. Still working to update some things.

jmarolf · 2021-02-22T18:09:36Z

@CyrusNajmabadi would appreciate your opinion here. I believe I will be able to unify on IOption2 type for codestyle and whitespace settings so those additional types will likely go away soon, but are there any other concerns about the approach taken here?

…e created

JohanLarsson · 2021-03-29T08:04:55Z

One thing that would be useful is a checkbox for disabling all rules in a group. One use case is when disabling all StyleCop documentation rules in a test project.

vatsalyaagrawal · 2021-03-29T16:57:41Z

@jmarolf Yay!! Looking forward to shipping this. 🎉🎉

jnm2 · 2021-04-02T23:41:40Z

One thing that would be useful is a checkbox for disabling all rules in a group. One use case is when disabling all StyleCop documentation rules in a test project.

I would expect it to be a single line disabling the category when possible, like with this StyleCop example.

jmarolf · 2021-04-03T00:28:55Z

@jnm2 got it: tracking here: #52388

mavasani · 2021-04-19T03:47:12Z

src/EditorFeatures/Core/EditorConfigSettings/Updater/SettingsUpdateHelper.cs

+
+namespace Microsoft.CodeAnalysis.Editor.EditorConfigSettings.Updater
+{
+    internal static partial class SettingsUpdateHelper


@jmarolf This file should not have been added. It duplicates a lot of functionality from ConfigurationUpdater used in Configure Severity lightbulb action, and leads to many inconsistencies between how editorconfig is updated under the covers from Editorconfig UX versus Configure Severity lightbulb action (#52720). Latter also handles updating category based severities, which I believe is a feature request for Editorconfig UX.

let me file a bug to explicitly track this. The intention was that I would send a cleanup PR to unify these implementations. As an aside: are there any tests for ConfigurationUpdater? I couldn't find any.

@jmarolf Not directly tested, but the tests in here (VB) and here (C#) test it indirectly (they test the CodeFixProvider which depends on ConfigurationUpdater)

ah, thank you

jmarolf requested a review from a team as a code owner February 8, 2021 16:44

ghost added the Area-IDE label Feb 8, 2021