[EE] Prettify compiler-generated field names with IDkmClrFullNameProvider.GetClrMemberName#50931
[EE] Prettify compiler-generated field names with IDkmClrFullNameProvider.GetClrMemberName#50931r-ramesh wants to merge 2 commits intodotnet:masterfrom
Conversation
Issue: - The debugger's NullReferenceException analysis feature figures out what was null through metadata and calls into the EE to display the offender as an expression. - If a field reference was null, we end up calling into GetClrMemberName. - However, for hoisted locals, etc we end up with an ugly mangled name like <myVar>5__1 was null. Changes: 1. Formatter: - Tweak implementation to handle compiler generated names. 2. CSharpFormatter: - Add implementation for C#. VB is still TODO. - Split up GeneratedNames so that it can be included in the CSharpResultProvider.
|
|
|
@tmat @ivanbasov Let me know your suggestions.. |
|
|
||
| index = -1; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Is it necessary to move these methods to a separate file? Moving the methods makes it difficult to track changes.
It looks like it is necessary to move the methods to allow including this file in ResultProvider.csproj.
Comparing this file with the previous version, it looks like the only change is including IndexOfBalancedParenthesis().
| /// <summary> | ||
| /// Parses a compiler-generated name and returns the simpler user-visible name. | ||
| /// </summary> | ||
| internal override string PrettifyCompilerGeneratedName(string name) |
There was a problem hiding this comment.
Perhaps SimplifyCompilerGeneratedName().
|
@cston Discussing this a bit further with the team I think it's better to have a new Concord API that is eventually implemented in Roslyn rather than piggybacking and overloading an existing one. I've added to you to the Concord PR.. |
Issue:
<myVar>5__1was null.Changes: