Skip to content

Fix MSBuildWorkspace Test when run on local machine#50619

Merged
13 commits merged intodotnet:masterfrom
jmarolf:bugfix/fix-local-run-msbuildworkspace-tests
Feb 4, 2021
Merged

Fix MSBuildWorkspace Test when run on local machine#50619
13 commits merged intodotnet:masterfrom
jmarolf:bugfix/fix-local-run-msbuildworkspace-tests

Conversation

@jmarolf
Copy link
Copy Markdown
Contributor

@jmarolf jmarolf commented Jan 19, 2021

Fixes #50258

@jmarolf jmarolf requested a review from a team as a code owner January 19, 2021 23:52
@ghost ghost added the Area-IDE label Jan 19, 2021
jasonmalinowski
jasonmalinowski reviewed Jan 25, 2021
View reviewed changes
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Feb 3, 2021 •
edited
Loading

This fix is necessary for the upcoming switch to using 16.9 Preview 3 images for our integration CI. To avoid any potential downtime due to this, perhaps we should force integration CI to run on the scouting image by hardcoding the queue to 'BuildPool.Windows.VS2019.Pre.Scouting.Open' and opening a tracking issue to revert the line once the non-scounting image is updated. Based on the schedule it is likely to move over on the 10th.

@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Feb 3, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 3, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Feb 4, 2021

@jasonmalinowski I removed the test and took all the "info" suggestions for the file.

@jasonmalinowski
Copy link
Copy Markdown
Member

jasonmalinowski commented Feb 4, 2021

@jmarolf We were continuing to chat in the Teams conversation and proposed to keep the test since it's now sounding like this is expected behavior, is that best to do now?

JoeRobich
JoeRobich reviewed Feb 4, 2021
View reviewed changes
@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Feb 4, 2021

@jasonmalinowski alright, added the test back conditionally

ghost
ghost approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

jasonmalinowski
jasonmalinowski reviewed Feb 4, 2021
View reviewed changes
@ghost ghost merged commit 6ce0ed7 into dotnet:master Feb 4, 2021
@ghost ghost added this to the Next milestone Feb 4, 2021
@jasonmalinowski jasonmalinowski mentioned this pull request Feb 11, 2021
Merged
@JoeRobich JoeRobich mentioned this pull request Feb 11, 2021
Merged
@RikkiGibson RikkiGibson modified the milestones: Next, 16.10.P1 Feb 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@JoeRobich JoeRobich JoeRobich approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE auto-merge

Projects

None yet

Milestone

16.10.P1

Development

Successfully merging this pull request may close these issues.

It looks like Microsoft.CodeAnalysis.MSBuild.UnitTests.MSBuildWorkspaceTests.TestOpenProject_AssemblyNameIsPath unit-test is flaky

4 participants

@jmarolf @JoeRobich @jasonmalinowski @RikkiGibson