Enable CA1822 in Visual Studio layer#50569
Conversation
.editorconfig
Outdated
| # Additionally, there is a risk of accidentally breaking an internal API that partners rely on though IVT. | ||
| dotnet_diagnostic.CA1822.severity = suggestion | ||
| # There is a risk of accidentally breaking an internal API that partners rely on though IVT. | ||
| dotnet_diagnostic.CA1822.severity = warning |
There was a problem hiding this comment.
This looks redundant as it's already specified above, but it's required due to #50577
| public class ResetInteractiveTests | ||
| { | ||
| private string WorkspaceXmlStr => | ||
| private const string WorkspaceXmlStr = |
There was a problem hiding this comment.
This is the only change to const.
|
@Youssef1313 FYI that I already attempted this locally in the past, but there are lot of internal APIs in the VisualStudio layer that are used via IVTs by internal partner teams, so this poses a big risk of introducing breaking changes. I think this will be a risky change and would certainly require validation and approval from @sharwell and @jinujoseph |
@mavasani I'm only changing private APIs. Any internal/public APIs are not touched. |
|
Thanks for the contribution @Youssef1313, Blocking this temporarily as we discuss with the team. |
|
@jinujoseph @mavasani Any updates on this? Note that I'm only touching |
|
@Youssef1313 thanks, given it is only for private APIs, it should be fine. I’ll review the PR. Thanks for your patience. |
|
@mavasani This is passing CI now. |
The issues stated were fixed and closed.