Implement ArgumentProvider base type and default provider#49909
Merged
sharwell merged 1 commit intodotnet:masterfrom Dec 15, 2020
Merged
Implement ArgumentProvider base type and default provider#49909sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
cde98fa to
cfd8df5
Compare
jmarolf
reviewed
Dec 15, 2020
|
|
||
| public override Task ProvideArgumentAsync(ArgumentContext context) | ||
| { | ||
| if (context.PreviousValue is { }) |
Contributor
Author
There was a problem hiding this comment.
No objection, but left it like this to expedite reviews on #49916.
jmarolf
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the trivial base provider for supporting #12363.