Track output operations in InteractiveHost#49710
Draft
sharwell wants to merge 1 commit intodotnet:mainfrom
Draft
Track output operations in InteractiveHost#49710sharwell wants to merge 1 commit intodotnet:mainfrom
sharwell wants to merge 1 commit intodotnet:mainfrom
Conversation
tmat
reviewed
Dec 2, 2020
| // This could happen, for example, for writers provided by the Interactive Window, | ||
| // and in the case where the window is being disposed. | ||
| Task.Run(() => | ||
| await Task.Run(() => |
Member
There was a problem hiding this comment.
await [](start = 12, length = 5)
Could this cause the problem that's described in the comment above?
Contributor
Author
There was a problem hiding this comment.
Only if the Process.Exited event is fired on the main thread.
Contributor
Author
There was a problem hiding this comment.
Not sure currently. I'll think about alternate ways to handle this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46414