Skip to content

Fix parenthesized pattern parsing#49621

Merged
jcouv merged 10 commits intodotnet:mainfrom
alrz:parenthesized-pattern-parsing
Mar 23, 2021
Merged

Fix parenthesized pattern parsing#49621
jcouv merged 10 commits intodotnet:mainfrom
alrz:parenthesized-pattern-parsing

Conversation

@alrz
Copy link
Copy Markdown
Member

@alrz alrz commented Nov 25, 2020

Fixes #49354

@alrz alrz requested a review from a team as a code owner November 25, 2020 17:53
@alrz alrz force-pushed the parenthesized-pattern-parsing branch from a9a9bde to 29a0d56 Compare November 25, 2020 18:46
@alrz alrz force-pushed the parenthesized-pattern-parsing branch from 68b6351 to 652f8a9 Compare November 25, 2020 19:27
@RikkiGibson RikkiGibson self-assigned this Nov 25, 2020
RikkiGibson
RikkiGibson reviewed Nov 25, 2020
View reviewed changes
@jcouv jcouv added the Feature - Pattern Matching Pattern Matching label Nov 26, 2020
@alrz alrz force-pushed the parenthesized-pattern-parsing branch from 95bb5a6 to 1bdc164 Compare November 28, 2020 17:39
@alrz alrz requested a review from RikkiGibson December 2, 2020 06:40
jcouv
jcouv reviewed Dec 10, 2020
View reviewed changes
jcouv
jcouv reviewed Dec 10, 2020
View reviewed changes
@jcouv jcouv self-assigned this Dec 10, 2020
@alrz alrz requested a review from jcouv December 11, 2020 08:36
@RikkiGibson RikkiGibson self-requested a review January 12, 2021 01:11
@AlekseyTs AlekseyTs added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jan 12, 2021
@alrz
Copy link
Copy Markdown
Member Author

alrz commented Jan 30, 2021

ping @RikkiGibson

@RikkiGibson
Copy link
Copy Markdown
Member

RikkiGibson commented Feb 23, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 23, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@RikkiGibson
Copy link
Copy Markdown
Member

RikkiGibson commented Feb 25, 2021

PTAL @jcouv

Base automatically changed from master to main March 3, 2021 23:53
@RikkiGibson
Copy link
Copy Markdown
Member

RikkiGibson commented Mar 8, 2021

@dotnet/roslyn-compiler Please review

@alrz alrz requested a review from a team March 19, 2021 15:20
jcouv
jcouv approved these changes Mar 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 10)

@jcouv jcouv merged commit c30efad into dotnet:main Mar 23, 2021
@ghost ghost added this to the Next milestone Mar 23, 2021
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Mar 23, 2021

Merged/squashed. Thanks @alrz!

@333fred 333fred mentioned this pull request Mar 25, 2021
Merged
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@RikkiGibson RikkiGibson

@jcouv jcouv

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - Pattern Matching Pattern Matching

Projects

None yet

Milestone

16.10.P2

Development

Successfully merging this pull request may close these issues.

C# compiler should compile parenthesized type pattern, which is a part of or-/and-pattern, without errors

6 participants

@alrz @RikkiGibson @jcouv @AlekseyTs @allisonchou @Dotnet-GitSync-Bot