Update Versions.props and PublishData.json for 16.9p2 snap #49586
Update Versions.props and PublishData.json for 16.9p2 snap #49586allisonchou merged 3 commits intomasterfrom
Conversation
|
Hello @allisonchou! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dibarbet
left a comment
There was a problem hiding this comment.
lgtm, just think we need to fix the version for packages from master-vs-deps
eng/config/PublishData.json
Outdated
| }, | ||
| "master-vs-deps": { | ||
| "nugetKind": ["Shipping", "NonShipping"], | ||
| "version": "3.8.*", |
There was a problem hiding this comment.
Predates this PR but this should be 3.9.* too, right @JoeRobich ?
There was a problem hiding this comment.
Good eye. Now I wonder how we use that property since nothing blew up...
There was a problem hiding this comment.
Updated! Thanks for the catch.
There was a problem hiding this comment.
Looking at the code, I actually cannot see it being used anywhere...
I see no references to the branch's version from the $data object anywhere- https://github.com/dotnet/roslyn/blob/d7048e7263cc33c888d3f46e6097ede64085199b/eng/publish-assets.ps1
No description provided.