Skip to content

Implement proposal 1 for type substitution#49441

Closed
jcouv wants to merge 12 commits intodotnet:masterfrom
jcouv:type-substitution0
Closed

Implement proposal 1 for type substitution#49441
jcouv wants to merge 12 commits intodotnet:masterfrom
jcouv:type-substitution0

Conversation

@jcouv
Copy link
Member

@jcouv jcouv commented Nov 17, 2020

@jcouv jcouv force-pushed the type-substitution0 branch 3 times, most recently from 199da77 to 5e4cf4f Compare November 17, 2020 22:46
@jcouv jcouv force-pushed the type-substitution0 branch from d655f4a to 30f9c6b Compare November 18, 2020 21:20
@jcouv jcouv force-pushed the type-substitution0 branch from ba91d3f to 7719499 Compare December 1, 2020 06:04
@jcouv
Copy link
Member Author

jcouv commented Dec 2, 2020

Closing in favor of #49723

This approach (simplifying the core type substitution logic) has repercussions which feel risky: what symbols are definitions, symbol equality rules, ...
A more targeted approach allows to fix most of the problem with much less risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing warnings on overriding a method with different nullability attributes

2 participants