Skip to content

Remove unwanted DataContract attribute#49422

Merged
RikkiGibson merged 2 commits intorelease/dev16.8from
dev/rigibson/remove-attribute
Nov 17, 2020
Merged

Remove unwanted DataContract attribute#49422
RikkiGibson merged 2 commits intorelease/dev16.8from
dev/rigibson/remove-attribute

Conversation

@RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Nov 17, 2020

Fixes a VS test break related to external users serializing instances of our types.

Have verified the fix locally, but still running automated validation over at https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/288168

@RikkiGibson
Copy link
Member Author

All checks have passed, except one integration leg had a spurious failure.

@RikkiGibson RikkiGibson changed the base branch from release/dev16.8-vs-deps to release/dev16.8 November 17, 2020 02:59
@RikkiGibson RikkiGibson force-pushed the dev/rigibson/remove-attribute branch from 06ea0a4 to bcecef4 Compare November 17, 2020 03:01
@RikkiGibson RikkiGibson marked this pull request as ready for review November 17, 2020 03:09
@RikkiGibson RikkiGibson requested a review from a team as a code owner November 17, 2020 03:09
@RikkiGibson RikkiGibson merged commit 2eaf704 into release/dev16.8 Nov 17, 2020
@RikkiGibson RikkiGibson deleted the dev/rigibson/remove-attribute branch November 17, 2020 03:51
@runfoapp runfoapp bot mentioned this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants