Further tweak rendering of inline hints#49213
Merged
CyrusNajmabadi merged 1 commit intodotnet:masterfrom Nov 7, 2020
Merged
Conversation
c7b6439 to
bab837b
Compare
bab837b to
714b8cc
Compare
JoeRobich
approved these changes
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While dogfooding i found an annoying problem that the current approach for inline hints changes the line height. This can lead to distracting tiny pixel shifting while using the feature. Also, the left/right padding of the tags was too tight, making it feel cramped.
Have tweaked to address both sides. It currently looks like: